[
https://issues.apache.org/jira/browse/SOLR-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14559980#comment-14559980
]
Anshum Gupta edited comment on SOLR-7183 at 5/26/15 10:25 PM:
--------------------------------------------------------------
I think it makes sense to just skip kdc dependent tests when we're running with
a blacklisted Locale.
P.S: I don't have a strong opinion so yes, if you want to save-restore the
Locale, go with it.
was (Author: anshumg):
I think it makes sense to just skip kdc dependent tests when we're running with
a blacklisted Locale.
> SaslZkACLProviderTest reproducible failures due to poor locale blacklisting
> ---------------------------------------------------------------------------
>
> Key: SOLR-7183
> URL: https://issues.apache.org/jira/browse/SOLR-7183
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Assignee: Gregory Chanan
> Attachments: SOLR-7183.patch
>
>
> SaslZkACLProviderTest has this blacklist of locales...
> {code}
> // These Locales don't generate dates that are compatibile with Hadoop
> MiniKdc.
> protected final static List<String> brokenLocales =
> Arrays.asList(
> "th_TH_TH_#u-nu-thai",
> "ja_JP_JP_#u-ca-japanese",
> "hi_IN");
> {code}
> ..but this list is incomplete -- notably because it only focuses on one
> specific Thai variant, and then does a string Locale.toString() comparison.
> so at a minimum {{-Dtests.locale=th_TH}} also fails - i suspect there are
> other variants that will fail as well....
> * if there is a bug in "Hadoop MiniKdc" then that bug should be filed in
> jira, and there should be Solr jira that refers to it -- the Solr jira URL
> needs to be included her in the test case so developers in the future can
> understand the context and have some idea of if/when the third-party lib bug
> is fixed
> * if we need to work around some Locales because of this bug, then Locale
> comparisons need be based on whatever aspects of the Locale are actually
> problematic
> see for example SOLR-6387 & this commit:
> https://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/contrib/morphlines-core/src/test/org/apache/solr/morphlines/solr/AbstractSolrMorphlineZkTestBase.java?r1=1618676&r2=1618675&pathrev=1618676
> Or SOLR-6991 + TIKA-1526 & this commit:
> https://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_5_0/solr/contrib/extraction/src/test/org/apache/solr/handler/extraction/ExtractingRequestHandlerTest.java?r1=1653708&r2=1653707&pathrev=1653708
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
