[
https://issues.apache.org/jira/browse/LUCENE-6500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14559185#comment-14559185
]
Uwe Schindler commented on LUCENE-6500:
---------------------------------------
I think the complexity to preserve reader structure was done in
ParallelCompositeReader before the change with getSequentialSubs. This was a
large refactoring (I also made the whole thing unmodifiable lists, to make sure
MultiReaders cannot be modified afterwards).
The main reason for MultiReaders is to make it possible for users to combine
readers as they like. But that is only during "construction" time. At "usage"
time, the structure is no longer interesting.
The problem with ParallelCompositeReader was just because it used this API,
because Java allows to call protected methods from same package... (which is a
bug in my opinion). Protected methods are just there for subclasses and should
be hidden to the outside! (my personal opinion).
> ParallelCompositeReader does not always call closed listeners
> -------------------------------------------------------------
>
> Key: LUCENE-6500
> URL: https://issues.apache.org/jira/browse/LUCENE-6500
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-6500-flatten.patch, LUCENE-6500.patch
>
>
> CompositeParallelReader misses to call closed listeners when the reader which
> is provided at construction time does not wrap leaf readers directly, such as
> a multi reader over directory readers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
