[
https://issues.apache.org/jira/browse/LUCENE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-6487:
---------------------------------
Attachment: LUCENE-6487.patch
Karl, I looked over your latest patch and made some modifications as follows
(now attached to this issue):
* GeoBaseBBox.isShapeInsideBBox: added optimization to exit early if found some
inside & outside
* PlanetModel.hashCode: optimize to not create new Double instances
* PlanetModel.toString(): prints SPHERE or WGS84 if applicable
* PlanetModel: added javadoc.
* Geo3dWGS84ShapeRectRelationTest: removed tabs
* I refactored the two tests extending RandomizedShapeTestCase to a new
Geo3dShapeRectRelationTestCase because they share so much in common.
"ant precommit" now passes. Tests pass... though I'd like to run some more
iterations which I'll do later.
Other comments:
GeoPoint.magnitude is a bit confusing to me… it seems it’s lazy initialized. I
think it could use comments to this effect? And why is there a
computeMagnitude() method distinct from super.magnitude() which also “computes”
the magnitude? I’m not saying I think there’s a bug in all this, just that, at
a minimum, there should be clarifying comments because it’s confusing.
Geo3dShapeRectRelationTestCase.geoPointToSpatial4jPoint (something I wrote) is
probably wrong since it uses ‘x’ and ‘y’ as if it’s lon & lat when it’s not;
and it doesn’t use ‘z’. How should this be rewritten?
> Add WGS84 capability to geo3d support
> -------------------------------------
>
> Key: LUCENE-6487
> URL: https://issues.apache.org/jira/browse/LUCENE-6487
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial
> Reporter: Karl Wright
> Attachments: LUCENE-6487.patch, LUCENE-6487.patch
>
>
> WGS84 compatibility has been requested for geo3d. This involves working with
> an ellipsoid rather than a unit sphere. The general formula for an ellipsoid
> is:
> x^2/a^2 + y^2/b^2 + z^2/c^2 = 1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
