[ 
https://issues.apache.org/jira/browse/LUCENE-6371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Woodward updated LUCENE-6371:
----------------------------------
    Attachment: LUCENE-6371.patch

Here's a patch taking into account all the comments here and on LUCENE-6494.
* SpanCollector becomes an interface again, so payload collection is entirely 
defined in the .payloads package
* BufferedSpanCollector is removed, replaced by a simple array of 
SpanCollectors in NearSpansOrdered.  SpanCollector has two methods to deal with 
this, newSubCollectors() and collectedComposite(), to create and then replay.
* SpanCollectors are passed through in getSpans().  A null passed here means no 
collection, and there's a default getSpans() call on SpanWeight that always 
passes a null collector.
* I've removed SpanSimilarity, in favour of passing a map of Terms to 
TermContexts to the SpanWeight constructor.  If this is null, then scoring 
isn't required; if not, then SpanWeight builds a SimScorer and passes that to 
its scorer.

> Improve Spans payload collection
> --------------------------------
>
>                 Key: LUCENE-6371
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6371
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Paul Elschot
>            Assignee: Alan Woodward
>            Priority: Minor
>             Fix For: Trunk, 5.3
>
>         Attachments: LUCENE-6371.patch, LUCENE-6371.patch, LUCENE-6371.patch, 
> LUCENE-6371.patch
>
>
> Spin off from LUCENE-6308, see the comments there from around 23 March 2015.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to