[
https://issues.apache.org/jira/browse/LUCENE-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555236#comment-14555236
]
Alan Woodward commented on LUCENE-6494:
---------------------------------------
bq. I personally think it makes sense for this to not be a blocker for 5.2 and
shipping this with 5.3 instead. Do you think that makes sense?
+1
I'm not sure I'll have svn access for the next couple of days, will you be able
to back this out of the 5.2 branch Anshum? If not, I can probably get to it on
Monday UK time (so before the release).
Regarding Rob's concerns:
* javadocs and commented out code I can sort out asap, the API sort of kept
changing every time I typed this afternoon so I didn't get round to getting
this into precommit-passing shape.
* I'll replace the no-op collector with null checks, that's a leftover from the
generics stuff
* MatchDataIterator and MatchDataCollector can be moved to the highlighter
package, I think (or sandbox initially, but the idea is to eventually build a
highlighter from them)
* I'll add stuff to AssertingSpans to enforce the contracts
* I think the boolean works best ('enablePositionCollection' maybe?) - will see
what works
Sorry about the timing here, I don't want to mess the release of 5.2 up!
> Make PayloadSpanUtil apply to other postings information
> --------------------------------------------------------
>
> Key: LUCENE-6494
> URL: https://issues.apache.org/jira/browse/LUCENE-6494
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Fix For: 5.2
>
> Attachments: LUCENE-6494.patch, LUCENE-6494.patch, LUCENE-6494.patch,
> LUCENE-6494.patch
>
>
> With the addition of SpanCollectors, we can now get arbitrary postings
> information from SpanQueries. PayloadSpanUtil does some rewriting to convert
> non-span queries into SpanQueries so that it can collect payloads. It would
> be good to make this more generic, so that we can collect any postings
> information from any query (without having to make invasive changes to
> already optimized Scorers, etc).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
