[
https://issues.apache.org/jira/browse/SOLR-7274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543359#comment-14543359
]
Anshum Gupta commented on SOLR-7274:
------------------------------------
Thanks for the patch Ishan. Here's some feedback:
# You've converted protected methods to be static protected, that doesn't sound
right to me. It makes more sense to merge the AuthenticationLayerFilter with
SDF and not change those methods. SDF is just a wrapper now and so this should
be easy to plugin. I'm not sure but it's perhaps just a matter of moving the
code into SDF.
# There are unused imports in your code, you should clean them up.
> Pluggable authentication module in Solr
> ---------------------------------------
>
> Key: SOLR-7274
> URL: https://issues.apache.org/jira/browse/SOLR-7274
> Project: Solr
> Issue Type: Sub-task
> Reporter: Anshum Gupta
> Attachments: SOLR-7274.patch, SOLR-7274.patch, SOLR-7274.patch,
> SOLR-7274.patch, SOLR-7274.patch, SOLR-7274.patch
>
>
> It would be good to have Solr support different authentication protocols.
> To begin with, it'd be good to have support for kerberos and basic auth.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
