[ 
https://issues.apache.org/jira/browse/LUCENE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503142#comment-14503142
 ] 

Uwe Schindler edited comment on LUCENE-6439 at 4/20/15 4:31 PM:
----------------------------------------------------------------

+1. The Maven changes should be a one-line change after my cleanup. I can help 
with that later.

We should also add the src/test dir to the forbidden-test ant target (it was 
redefined to only check src/java). It should check both for forbidden 
signatures in tests.txt.

For Maven this is just adding the goal in the redefinition 
{{<goals><goal>check</goal><goal>testCheck<goal></goals>}}. I can do this.


was (Author: thetaphi):
+1. The Maven changes should be a one-line change after my cleanup. I can help 
with that later.

We should also add the src/test dir to the forbidden-test ant macro (it was 
redefined to only check src/java). It should check both for forbidden 
signatures in tests.txt.

For Maven this is just adding the goal in the redefinition 
{{<goals><goal>check</goal><goal>testCheck<goal></goals>}}. I can do this.

> Create test-framework/src/test
> ------------------------------
>
>                 Key: LUCENE-6439
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6439
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Robert Muir
>         Attachments: LUCENE-6439.patch
>
>
> We have quite a few tests (~30 suites) for test-framework stuff 
> ("test-the-tester") but currently they all sit in lucene/core housed with 
> real tests.
> I think we should just give test-framework a src/test and move these tests 
> there. This makes the build simpler in the future too, because its less 
> "special". 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to