[
https://issues.apache.org/jira/browse/SOLR-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485639#comment-14485639
]
Uwe Schindler commented on SOLR-7355:
-------------------------------------
bq. Erick: I did set the eol-style on the new files, required to pass
precommit. It's thoroughly mystifying.
Those eol-style setting are not used if you apply the patch with standard patch
command. "svn patch" applies those settings. So you have 2 options:
- apply patch with "svn patch" command - this will handle all
renames/moves/deletes and also properties
- use default patch command of OS, but this will not handle moves/deletes and
not apply properties. You have to do all of this manually after patching (svn
add new files, svn remove old files, add properties).
> Java 8: ConcurrentLinkedHashMap -> Caffeine
> -------------------------------------------
>
> Key: SOLR-7355
> URL: https://issues.apache.org/jira/browse/SOLR-7355
> Project: Solr
> Issue Type: Task
> Reporter: Ben Manes
> Priority: Minor
> Attachments: SOLR-7355.patch, SOLR-7355.patch, SOLR-7355.patch,
> SOLR-7355.patch
>
>
> When Solr transitions to requiring Java 8, please upgrade to Caffeine. The
> performance should be relatively the same. The per-instance memory usage
> should be smaller and Solr may decide to opt-in to use some of the additional
> features. The only drawback is that the jar size is larger due to code
> generation, though that may be trimmed over time and usually is not a concern
> for server-side applications.
> ConcurrentLinkedHashMap changes will continue to be minimal, even more so
> now, and driven by requests from Java 6 users unable to upgrade. Caffeine is
> ideally the upgrade path for Guava cache users too, which due to Android
> cannot be significantly modified.
> Caffeine: https://github.com/ben-manes/caffeine
> Benchmarks: https://github.com/ben-manes/caffeine/wiki/Benchmarks
> ConcurrentLinkedHashMap: https://code.google.com/p/concurrentlinkedhashmap
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
