[
https://issues.apache.org/jira/browse/SOLR-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985519#action_12985519
]
Ryan McKinley commented on SOLR-2292:
-------------------------------------
bq. Yet SimpleOrderedMap only extends NamedList!!! Its still a linear search!
FYI, the distinction between NamedList and SimpleOrderedMap is *only* in how
they are written to json. In java API they are identical, but in json
SimpleOrderedMap is {"foo":10,"bar":20} and NamedList shows ["foo",10,"bar",20]
http://lucene.apache.org/solr/api/org/apache/solr/common/util/SimpleOrderedMap.html
> Lock down NamedList API, remove inefficent and esoteric methods
> ---------------------------------------------------------------
>
> Key: SOLR-2292
> URL: https://issues.apache.org/jira/browse/SOLR-2292
> Project: Solr
> Issue Type: Task
> Reporter: Hoss Man
> Fix For: 3.1
>
>
> Over in SOLR-2288, rmuir made some good points about locking down the
> NamedList API to protect people...
> {quote}
> I looked at your patch, and personally I think NamedList should really be
> type-safe.
> If users want to use it in a type-unsafe way, thats fine, but *the container
> itself shouldn't be List<Object>*.
> {quote}
> ...
> {quote}
> Separately, i just want to say the following about NamedList:
> All uses of this API should really be reviewed. I'm quite aware that it warns
> you about the fact that its slow for certain operations,
> but in my opinion these *slow operations such as get(String, int) should be
> deprecated and removed*.
> Any users that are using NamedList in this way, especially in loops, are very
> likely using the wrong datastructure.
> {quote}
> (emphasis added by me)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
