[
https://issues.apache.org/jira/browse/SOLR-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362286#comment-14362286
]
Xu Zhang commented on SOLR-6350:
--------------------------------
Thanks so much Hoss :) .
I think I fix the NaN errors, which is because my patch doesn't compute
percentile stats with the new trunk change. This also shows the edge case:
when user asking percentiles for empty document set, we will give NaN.
{quote}
I didn't do any in depth review yet, but i did sprinkle some nocommits arround
related to things that jumped out at me while resolving conflicts
{quote}
Some work seems quite dirty to me, will spend some time to improve that. For
example, we have a test case which will test all stats combinations, I just
exclude percentiles right now, which is quite awful.
And another thing is I didn't do too much performance tests around this. There
are plenty of parameters for Tdigest. I just pick a default number and
ArrayDigest.
{quote}
I didn't notice any distributed test, not sure if that's something still
needing done, or if that was just because of a mistake in creating the patch
file and "new files" weren't included.
{quote}
I just added 4 simple test cases in the TestDistributedSearch.java. I probably
missed them in my last patch. Have them back.
{quote}
BTW: no need ot put your name as a suffix in the patch filename – convention is
to just name the patch after the jira. The only reason to worry about
distinguishing the file names is in cases where you explicitly posting a
"variant" patch (ie: a strawman that you feel/know is broken and shouldn't be
taken seriously long term, an alternative proposal to some other existing
patch, an orthogonal patch only containing tests or some other independent
changes, etc...)
{quote}
Ha, thanks a lot.
> Percentiles in StatsComponent
> -----------------------------
>
> Key: SOLR-6350
> URL: https://issues.apache.org/jira/browse/SOLR-6350
> Project: Solr
> Issue Type: Sub-task
> Reporter: Hoss Man
> Attachments: SOLR-6350-Xu.patch, SOLR-6350-Xu.patch,
> SOLR-6350-xu.patch, SOLR-6350-xu.patch, SOLR-6350.patch, SOLR-6350.patch
>
>
> Add an option to compute user specified percentiles when computing stats
> Example...
> {noformat}
> stats.field={!percentiles='1,2,98,99,99.999'}price
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
