[ 
https://issues.apache.org/jira/browse/LUCENE-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338409#comment-14338409
 ] 

Michael McCandless commented on LUCENE-6299:
--------------------------------------------

bq. I would prefer IOException.

IOExc is a good idea, I'll switch to that.

bq. Also on 4.x, we should not change the signatures of DR etc to 'throws 
IOException' either, I think its too heavy of a break?

I think we shouldn't backport that change to 4.x?  I was just going to fix the 
IW bugs and add the test cases (except maybe the addIndexes test cases since 
they added RawDirectoryWrapper).

> IndexWriter's enforcement of 2.1B doc limits is buggy
> -----------------------------------------------------
>
>                 Key: LUCENE-6299
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6299
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Blocker
>             Fix For: 4.10.4, 5.0, Trunk, 5.1
>
>         Attachments: LUCENE-6299.patch, LUCENE-6299_addIndexes.patch
>
>
> E.g. if you pass an already > 2.1B docs to either addIndexes, it can fail to 
> enforce properly.
> IW's private reserveDocs should refuse to accept negative values.
> IW.deleteAll fails to set the pendingNumDocs to 0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to