[ 
https://issues.apache.org/jira/browse/LUCENE-6256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328575#comment-14328575
 ] 

ASF subversion and git services commented on LUCENE-6256:
---------------------------------------------------------

Commit 1661061 from [~rjernst] in branch 'dev/trunk'
[ https://svn.apache.org/r1661061 ]

LUCENE-6256: Change PostingsEnum.nextPosition() to consistently return -1 when 
positions are not available

> PostingsEnum impls should respect documented behavior when no positions exist
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-6256
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6256
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Ryan Ernst
>         Attachments: LUCENE-6256.patch
>
>
> {{PostingsEnum.nextPositions}} says that if no positions exist, 
> NO_MORE_POSITIONS will be returned on the first call (actually it refers to 
> DocsEnum.NO_MORE_DOCS, which should be changed since DocsEnum doesn't exist 
> on trunk).  At least one impl (BlockDocsEnum) does {{assert false}} inside 
> {{nextPosition()}}.  This means if you have assertions turned on (e.g. in a 
> test) you get an assertion here, when the behavior should return 
> NO_MORE_POSITIONS.  I'm still going through all the implementations, but I 
> also see {{MultiTermHighlighting}} which returns {{Integer.MAX_VALUE}}.  I 
> think we should clean up all these implementations which have no positions 
> (including maybe the fake scorers that are copied around in a lot of places?) 
> to return NO_MORE_POSITIONS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to