[
https://issues.apache.org/jira/browse/LUCENE-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323337#comment-14323337
]
Paul Elschot edited comment on LUCENE-6250 at 2/16/15 9:40 PM:
---------------------------------------------------------------
The patch of 20150216 passes down the asTwoPhaseIterator() call from SpanScorer
to Spans and implements that on TermSpans.
It also contains some commented code (for debugging) and lots of System.out.
With the patch applied to trunk, this test case:
ant test -Dtestcase=TestSpansAdvanced
-Dtests.method=testBooleanQueryWithSpanQueries -Dtests.seed=E42AB3F90E47161
fails because a SpanScorer is called while it is still at docID -1, and I am
stuck trying to figure this out.
Some questions:
Is this basic approach right?
How to pass this above test?
When I started investigating this test case I was confused by BooleanWeight
creating an unused SpansScorer while trying to create a BooleanScorer.
Shall I open another issue to separate the condition to actually use a
BooleanScorer from the creation of the BooleanScorer (in BooleanWeight)?
Can the TestFilterSpans class be removed? It only checks that all abstract Span
methods are implemented.
was (Author: [email protected]):
The patch of 20150216 passes down the asTwoPhaseIterator() call from SpanScorer
to Spans and implements that on TermSpans.
It also contains some commented code (for debugging) and lots of System.out.
With the patch applied to trunk, this test case:
ant test -Dtestcase=TestSpansAdvanced
-Dtests.method=testBooleanQueryWithSpanQueries -Dtests.seed=E42AB3F90E47161
fails because a SpanScorer is called while it is still at docID -1, and I am
stuck trying to figure this out.
Some questions:
Is this basic approach right?
How to pass this above test?
When I started investigating this test case was confused by BooleanWeight
creating an unused SpansScorer while trying to create a BooleanScorer.
Shall I open another issue to separate the condition to actually use a
BooleanScorer from the creation of the BooleanScorer (in BooleanWeight)?
Can the TestFilterSpans class be removed? It only checks that all abstract Span
methods are implemented.
> Approximations on Spans
> -----------------------
>
> Key: LUCENE-6250
> URL: https://issues.apache.org/jira/browse/LUCENE-6250
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Paul Elschot
> Attachments: ApproxSpans-20150216a.patch
>
>
> Approximate spans using existing conjunction/disjunction approximations
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
