[
https://issues.apache.org/jira/browse/SOLR-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320316#comment-14320316
]
Erick Erickson commented on SOLR-2649:
--------------------------------------
[~greg.pendlebury] (and others). Thanks for pinging...
Wow, this has been hanging around for a _long_ time. It looks just fell off
people's radar.
[[email protected]] [~janhoy] [~elyograg] et.al. I can shepherd this
patch through, but don't really have the background here to weigh in on the
merits of the fix. I'll volunteer to run the mechanics though, and do a code
review to see what I can see but I'm looking for whether the proposals are a
go/no-go from a correctness perspective. This looks like it'll change current
behavior which makes me nervous. Of course if it changes incorrect behavior
it's a no-brainer.
Problem is that this has languished and the patch will not apply to trunk.
Could someone update the patch? A couple of things:
1> Just upload repeated copies of SOLR-2649.patch without changing the name.
That way it's much easier to keep track of what the latest one is. I tried
applying the most recent one and it failed, but guessed the most recent one was
the correct one.
2> Please create the patch against the current trunk. Part of the check in
process is to merge it back into 5x so no separate patch is (usually) needed.
> MM ignored in edismax queries with operators
> --------------------------------------------
>
> Key: SOLR-2649
> URL: https://issues.apache.org/jira/browse/SOLR-2649
> Project: Solr
> Issue Type: Bug
> Components: query parsers
> Reporter: Magnus Bergmark
> Priority: Minor
> Fix For: 4.9, Trunk
>
> Attachments: SOLR-2649-with-Qop.patch, SOLR-2649.diff, SOLR-2649.patch
>
>
> Hypothetical scenario:
> 1. User searches for "stocks oil gold" with MM set to "50%"
> 2. User adds "-stockings" to the query: "stocks oil gold -stockings"
> 3. User gets no hits since MM was ignored and all terms where AND-ed
> together
> The behavior seems to be intentional, although the reason why is never
> explained:
> // For correct lucene queries, turn off mm processing if there
> // were explicit operators (except for AND).
> boolean doMinMatched = (numOR + numNOT + numPluses + numMinuses) == 0;
> (lines 232-234 taken from
> tags/lucene_solr_3_3/solr/src/java/org/apache/solr/search/ExtendedDismaxQParserPlugin.java)
> This makes edismax unsuitable as an replacement to dismax; mm is one of the
> primary features of dismax.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
