[ 
https://issues.apache.org/jira/browse/SOLR-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293615#comment-14293615
 ] 

Shawn Heisey commented on SOLR-4586:
------------------------------------

I believe that Rob's recent job change does present a conflict of interest when 
it comes to Solr, although he's a really intelligent person and when he's got a 
strong technical argument, I'm inclined to listen.  His concerns on LUCENE-4835 
stand, although I think the issue notes do leave room for further discussion on 
an increase in the default value, just not to Integer.MAX_VALUE, and I've 
brought it up there.

As the head of this project in Jira, my thinking is that [[email protected]] 
is the deciding vote.  Given that he's already removed the limit in 
heliosearch, I think I know where that vote would land.

I stand ready for the following changes, if/when we can reach consensus:

 * In Solr 5.1, default maxBooleanClauses to MAX_VALUE and ignore the config 
value.
 * In Solr 6.0, throw an error if maxBooleanClauses is found in solrconfig.xml. 
(not strongly tied to this one)

If that test still shows intermittent failures, I don't know if I can fix the 
problem, but I can definitely try.

If we don't remove the limit, the error message in Solr when the count is 
exceeded should probably say "consider using the terms query parser instead."  
I'm inclined to have it point at the wiki or reference guide also.


> Eliminate the maxBooleanClauses limit
> -------------------------------------
>
>                 Key: SOLR-4586
>                 URL: https://issues.apache.org/jira/browse/SOLR-4586
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.2
>         Environment: 4.3-SNAPSHOT 1456767M - ncindex - 2013-03-15 13:11:50
>            Reporter: Shawn Heisey
>         Attachments: SOLR-4586.patch, SOLR-4586.patch, SOLR-4586.patch, 
> SOLR-4586.patch, SOLR-4586.patch, SOLR-4586.patch, 
> SOLR-4586_verify_maxClauses.patch
>
>
> In the #solr IRC channel, I mentioned the maxBooleanClauses limitation to 
> someone asking a question about queries.  Mark Miller told me that 
> maxBooleanClauses no longer applies, that the limitation was removed from 
> Lucene sometime in the 3.x series.  The config still shows up in the example 
> even in the just-released 4.2.
> Checking through the source code, I found that the config option is parsed 
> and the value stored in objects, but does not actually seem to be used by 
> anything.  I removed every trace of it that I could find, and all tests still 
> pass.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to