[ 
https://issues.apache.org/jira/browse/LUCENE-6194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288354#comment-14288354
 ] 

Dawid Weiss commented on LUCENE-6194:
-------------------------------------

You could, but if a given test does have iteration-related dependencies (for 
example leaks memory and only fails after N iterations) then you would have a 
misleading message as well... There is no "right" scenario to cover all 
possible situations I think. The understanding of what these "components" of 
the random seed are (in correlation with test reiterations) is crucial; no 
single "reproduce with" message is going to be helpful in all situations.

The best way to signal an error would be to display this...
{code}
test seed: x:y
test iterations: z
see explanation of how randomization and repeated tests work: [here]
{code}

Another way to say it is that you can change the message any way you like, in 
the end somebody will be confused by the "reproduce with" message. :)

> Reproduce with should include -Dtests.iters=N
> ---------------------------------------------
>
>                 Key: LUCENE-6194
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6194
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/test-framework
>            Reporter: Michael McCandless
>            Priority: Minor
>
> I was playing with the patch on LUCENE-6066, and hit a test failure, but then 
> the "Reproduce with: " failed to reproduce, which threw me for a bit of a 
> loop, until I realized it was missing the -Dtests.iters=N.
> To see this, apply the patch on LUCENE-6066 to trunk and then run this:
> {noformat}
> ant test  -Dtestcase=TestPriorityQueue 
> -Dtests.method=testRemovalsAndInsertions* -Dtests.seed=2576D26D551748E5 
> -Dtests.slow=true 
> -Dtests.linedocsfile=/lucenedata/hudson.enwiki.random.lines.txt 
> -Dtests.locale=ru_RU -Dtests.timezone=Europe/Paris -Dtests.asserts=true 
> -Dtests.file.encoding=UTF-8 -Dtests.iters=10
> {noformat}
> (or just insert a random test failure into e.g. TestDemo or something).
> It should fail, but the "Reproduce with: ..." line does not include 
> -Dtests.iters=10.  I think it should?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to