[
https://issues.apache.org/jira/browse/LUCENE-6167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14270878#comment-14270878
]
Adrien Grand commented on LUCENE-6167:
--------------------------------------
I think there is a typo. The if statement should check {{ord2}} right?
{code}
+ if (ord1 == -1) {
+ ord2 = missingOrd;
+ }
{code}
Otherwise I think this is good. Maybe the patch could be changed so that the
string improvement also works if you have several sort fields by doing the
instanceof check for each comparator? I would also be interesting to see if the
string comparator could be refactored so that this special case is not needed
anymore.
> Speed up SortingMergePolicy by string
> -------------------------------------
>
> Key: LUCENE-6167
> URL: https://issues.apache.org/jira/browse/LUCENE-6167
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Robert Muir
> Attachments: LUCENE-6167.patch
>
>
> Building the sorted docmaps can take a nontrivial amount of time, for String
> we currently don't do a very good job.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
