[
https://issues.apache.org/jira/browse/SOLR-6897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265524#comment-14265524
]
Hoss Man commented on SOLR-6897:
--------------------------------
{code}
===================================================================
--- solr/core/src/java/org/apache/solr/core/SolrConfig.java (revision
1648550)
+++ solr/core/src/java/org/apache/solr/core/SolrConfig.java (revision )
@@ -192,7 +192,6 @@
defaultIndexConfig = mainIndexConfig = null;
indexConfigPrefix = "indexConfig";
}
- nrtMode = getBool(indexConfigPrefix+"/nrtMode", true);
// Parse indexConfig section, using mainIndex as backup in case old config
is used
indexConfig = new SolrIndexConfig(this, "indexConfig", mainIndexConfig);
{code}
this change should follow the same pattern we use anytime we stop supporting a
config option:
* check config to see if it's specified, and if so log a warning
* commit & backport
* update trunk to change warning log to fatal error & note it in X.0 (6.0 in
this case) "upgrading" instructions.
(this is why methods like SolrIndexConfig.assertWarnOrFail exist .. perhaps
that method should be promoted to protected in Config.java?)
> Nuke non-NRT mode from code and configuration
> ---------------------------------------------
>
> Key: SOLR-6897
> URL: https://issues.apache.org/jira/browse/SOLR-6897
> Project: Solr
> Issue Type: Task
> Reporter: Shalin Shekhar Mangar
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6897.patch
>
>
> We've had nrtMode as a configurable param in solrconfig.xml. This was maybe
> necessary in the early days when were testing the waters for NRT searchers
> but it is not necessary anymore. We should just nuke it and have only NRT
> mode always.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
