[
https://issues.apache.org/jira/browse/LUCENE-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979178#action_12979178
]
Michael McCandless commented on LUCENE-2828:
--------------------------------------------
We won't fix this for 3.x or 4.0, since we've deprecated SimilarityDelegator,
and forced hard cutover from Sim.lengthNorm -> Sim.computeNorm (LUCENE-2854).
But I'll leave this open in case we do another 2.9/3.0 release.
> SimilarityDelegator broke back-compat for subclasses overriding lengthNorm
> --------------------------------------------------------------------------
>
> Key: LUCENE-2828
> URL: https://issues.apache.org/jira/browse/LUCENE-2828
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 2.9, 2.9.1, 2.9.2, 2.9.3, 2.9.4, 3.0, 3.0.1, 3.0.2, 3.0.3
> Reporter: Michael McCandless
> Fix For: 2.9.5, 3.0.4
>
> Attachments: LUCENE-2828.patch
>
>
> In LUCENE-1420, we added Similarity.computeNorm to let the norm computation
> have access to the raw information (length, boost, etc.).
> But this class broke back compat with SimilarityDelegator. We did add
> computeNorm there, but, it's impl just forwards to the delegee's computeNorm.
> In the case where a subclass of SimilarityDelegator overrides lengthNorm,
> that method will no longer be invoked.
> Not quite sure how to fix this since, somehow, we have to determine whether
> the delegee's impl of computeNorm should be favored over the subclasses impl
> of the "legacy" lengthNorm.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
