[ 
https://issues.apache.org/jira/browse/LUCENE-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241260#comment-14241260
 ] 

Robert Muir commented on LUCENE-6105:
-------------------------------------

This change looks great! 

I am just worried about 4.10.3, it seems like bad timing to make a last minute 
FST change. Can we be conservative here? I would prefer we make this change 
normally and if its appropriate, finds its way to 4.10.4. Bug fix releases are 
supposed to be easy.


> Don't create root arc cache for tiny FSTs
> -----------------------------------------
>
>                 Key: LUCENE-6105
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6105
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/FSTs
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: Trunk, 5.x, 4.10.x
>
>         Attachments: LUCENE-6105.patch
>
>
> The purpose of the root arc cache is to speed up lookups for ASCII terms, but 
> it adds high overhead if the FST is already tiny.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to