[
https://issues.apache.org/jira/browse/LUCENE-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer updated LUCENE-2831:
------------------------------------
Attachment: LUCENE-2831.patch
next iteration, this time I think we are very close.
- I renamed AtomicContext to AtomicReaderContext and likewise for
CompositeContext
- s/topLevelReaderContext/getTopReaderContext
- updated to latest trunk and adopted the changes to IS in LUCENE-2837
- Removed the dummy searcher in QueryWrapperFilter which now works just fine
with a IS instance
- added ReaderContext ctors to IS
- replaced some members in IS in favor of AtomicReader[] leaves <--- leafs :)
- s/leafs/leaves
- Sharpened the JDocs in Weight - review please
- added missing JDocs to IR, IS & ReaderContext + subs
{quote}
Should Filter.getDocIDSet take an AtomicReaderContext? We don't have
to do that in this patch, though... this patch is a big enough first
step!
{quote}
Yeah I would like to do so, similar to Weight#scorer but currently mainly solr
prevents us from this. There is also the functionqueries that still operate on
IR instead of ReaderContext but maybe this is a good usecase to consolidate
them move them into a module and get them out of core?!
Anyway, we should do this in a different issue - this has its purpose as you
stated.
Likewise I would do issues for CachingWrapperFilter & DuplcateFilter though.
simon
> Revise Weight#scorer & Filter#getDocIdSet API to pass Readers context
> ---------------------------------------------------------------------
>
> Key: LUCENE-2831
> URL: https://issues.apache.org/jira/browse/LUCENE-2831
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-2831.patch, LUCENE-2831.patch, LUCENE-2831.patch
>
>
> Spinoff from LUCENE-2694 - instead of passing a reader into Weight#scorer(IR,
> boolean, boolean) we should / could revise the API and pass in a struct that
> has parent reader, sub reader, ord of that sub. The ord mapping plus the
> context with its parent would make several issues way easier. See
> LUCENE-2694, LUCENE-2348 and LUCENE-2829 to name some.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
