[
https://issues.apache.org/jira/browse/LUCENE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230773#comment-14230773
]
Hoss Man commented on LUCENE-5961:
----------------------------------
I'm -0 to backporting this to 4.10.x...
I'm not convinced the benefits of the "fixed" behavior out-weigh the risk that
this will cause problems for existing users who have code that depends on the
current behavior, and will expect 4.10.3 to be a drop in replacement w/o
needing to modify any of their lucene client code or solr queries/configs.
I'd rather let this fix wait for 5.0 (or a 4.11 if there was going to be one),
when affected users are more likely to pay attention to MIGRATE.txt and the
Solr upgrade instructions and take the time to fix their code/configs/queries
if they really want the existing broken behavior...
https://svn.apache.org/viewvc/lucene/dev/trunk/lucene/MIGRATE.txt?r1=1632414&r2=1632413&pathrev=1632414
https://svn.apache.org/viewvc/lucene/dev/trunk/solr/CHANGES.txt?r1=1632414&r2=1632413&pathrev=1632414
> FunctionValues.exist(int) isn't returning false in cases where it should for
> many "math" based value sources
> ------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-5961
> URL: https://issues.apache.org/jira/browse/LUCENE-5961
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Hoss Man
> Assignee: Hoss Man
> Fix For: 4.10.3, 5.0, Trunk
>
> Attachments: LUCENE-5961.patch, LUCENE-5961.patch, LUCENE-5961.patch
>
>
> The FunctionValues class contains an exist(int doc) method with a default
> implementation that returns true - field based DocValues override this method
> as appropriate, but most of the "function" based subclasses in the code
> (typically anonymous subclasses of "FloatDocValues") don't override this
> method when wrapping other ValueSources.
> So for example: the FunctionValues returned by
> ProductFloatFunction.getValues() will say that a value exists for any doc,
> even if that ProductFloatFunction wraps two FloatFieldSources that don't
> exist for any docs
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
