[ 
https://issues.apache.org/jira/browse/SOLR-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomás Fernández Löbbe updated SOLR-6704:
----------------------------------------
    Attachment: SOLR-6704.patch

Looks like this was caused by SOLR-6211. [~steve_rowe], you proposed not 
calling {{super.init()}} from {{init()}} and instead override 
{{hasProperty(p)}} and {{isMultiValued()}}. {{properties}} are never set in the 
wrapped instance because {{setArgs}} is never called. If we call 
{{wrappedField.setArgs}} like I did in my initial patch, then we need to make 
sure anything that requires properties is delegated to wrappedField. If instead 
we do {{super.init()}} from {{init()}} this is not needed. 
Here is a patch (for branch 4.10.x) with these changes, old and new tests 
passing. Any thoughts?

> TrieDateField type drops schema properties in branch 4.10
> ---------------------------------------------------------
>
>                 Key: SOLR-6704
>                 URL: https://issues.apache.org/jira/browse/SOLR-6704
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.10.2
>            Reporter: Tomás Fernández Löbbe
>            Assignee: Tomás Fernández Löbbe
>         Attachments: SOLR-6704.patch, SOLR-6704.patch, testcases.patch
>
>
> Properties set in the FieldType, like multiValued, docValues, etc are dropped 
> on TrieDateField type.
> This is only happening in the 4.10 branch, 5x and trunk don't seem to have 
> this issue. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to