+1 for “manual”. Furthermore, I think specifying the router should become mandatory or default to the has based router. For back-compat, we can keep current behavior but output a warning about what choice was made.
~ David Smiley Freelance Apache Lucene/Solr Search Consultant/Developer http://www.linkedin.com/in/davidwsmiley On Thu, Oct 16, 2014 at 11:03 AM, Shawn Heisey <[email protected]> wrote: > I had this exchange with an IRC user named "kindkid" this morning: > > ----------------- > 08:30 < kindkid> I'm using sharding with the implicit router, but I'm > seeing > all my documents end up on just one of my 24 shards. What > might be causing this? (4.10.0) > 08:35 <@elyograg> kindkid: you used the implicit router. that means that > documents will be indexed on the shard you sent them > to, not > routed elsewhere. > 08:37 < kindkid> oh. wow. not sure where I got the idea, but I was under > the > impression that implicit router would use a hash of the > uniqueKey modulo number of shards to pick a shard. > 08:38 <@elyograg> I think you probably wanted the compositeId router. > 08:39 <@elyograg> implicit is not a very good name. It's technically > correct, > but the meaning of the word is not well known. > 08:39 <@elyograg> "manual" would be a better name. > ----------------- > > The word "implicit" has a very specific meaning, and I think it's > absolutely correct terminology for what it does, but I don't think that > it's very clear to a typical person. This is not the first time I've > encountered the confusion. > > Could we deprecate the implicit name and use something much more > descriptive and easily understood, like "manual" instead? Let's go > ahead and accept implicit in 5.x releases, but issue a warning in the > log. Maybe we can have a startup system property or a config option > that will force the name to be updated in zookeeper and get rid of the > warning. If we do this, my bias is to have an upgrade to 6.x force the > name change in zookeeper. > > Thanks, > Shawn > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
