[ 
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152025#comment-14152025
 ] 

Steve Rowe commented on SOLR-6476:
----------------------------------

Previously mentioned outstanding issues:

# One of the tests should have a non-trivial fieldtype definition, like at 
least one analyzer.
# SchemaManager has lots of non-generic collections - I looked at a couple, and 
they could be generified - maybe they all could?
# Most of the {{add\*()}} javadocs in {{IndexSchema}} say that persistence 
always happens, but it doesn't if persist=false

New things I noticed today:

# {{SchemaManager}} has zero javadocs.  More would be good.
# AFAICT, a bulk Schema API request with a new field using a new field type in 
the same request can fail depending on the order of the specified operations, 
e.g. this will fail because "newtype" won't exist when {{SchemaManager}} tries 
to add "newfield" (caveat: untested):
\\
{code:javascript}
{
  "add-field" : { "name":"newfield", "type":"newtype" }, 
  "add-field-type" : { "name":"newtype", "class":"solr.StrField" }
}
{code}

> Create a bulk mode for schema API
> ---------------------------------
>
>                 Key: SOLR-6476
>                 URL: https://issues.apache.org/jira/browse/SOLR-6476
>             Project: Solr
>          Issue Type: Bug
>          Components: Schema and Analysis
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>              Labels: managedResource
>         Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, 
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is 
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example 
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H 
> 'Content-type:application/json'  -d '{
>     "add-field": {
>         "name":"sell-by",
>         "type":"tdate",
>         "stored":true
>     },
>     "add-field":{
>         "name":"catchall",
>         "type":"text_general",
>         "stored":false
>     }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to