[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144491#comment-14144491
]
Steve Rowe commented on SOLR-6476:
----------------------------------
Noble, I looked at your latest patch and I found a few issues:
# The bulk schema api should be added to {{TestCloudManagedSchemaConcurrent}}
# {{TestBulkSchemaAPI}} has lots of backslash-double-quotes in JSON strings -
those are way easier to look at if you convert the backslash-double-quotes to
single-quotes and pass the string to the {{json()}} method.
# One of the tests should have a non-trivial fieldtype definition, like at
least one analyzer.
# In {{SchemaManager.doOperation()}}, you limit retries to {{MAX_TRIES}} when
there is a {{SchemaChangedInZkException}}, but none of the other schema APIs do
that - why not let it continue until success?
# {{SchemaManager.ADD_FIELD_TYPE}} should be "add-field-type" instead of
"add-type". (Solr could introduce a non-field type at some point in the
future; even with "\-field\-" added, it's still not the longest command.)
# {{SchemaManager}} has lots of non-generic collections - I looked at a couple,
and they could be generified - maybe they all could?
# {{IndexSchema.addDynamicFields()}} is missing the {{persist}} param you added
to all the other {{add\*()}} methods; also, it always persists, even when
called from the bulk mode schema api.
# Most of the {{add\*()}} javadocs in {{IndexSchema}} say that persistence
always happens, but it doesn't if persist=false
> Create a bulk mode for schema API
> ---------------------------------
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
> Reporter: Noble Paul
> Assignee: Noble Paul
> Labels: managedResource
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
