[
https://issues.apache.org/jira/browse/LUCENE-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137749#comment-14137749
]
Michael McCandless commented on LUCENE-5958:
--------------------------------------------
Patch looks great, I love the "really bad day" comment.
In IFD.ensureOpen, we currently check for writer == null case, but your new
writer.tragedy check doesn't check for that ... but then I don't think it's
possible for writer to be null: it's final, and we pass to ctor, and IFD is
only ever created by IW, and IW passes "this" to it, so I think just remove the
null check?
> OOM or exceptions during checkpoint make IndexWriter have a bad day
> -------------------------------------------------------------------
>
> Key: LUCENE-5958
> URL: https://issues.apache.org/jira/browse/LUCENE-5958
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-5958.patch
>
>
> During finishCommit(), we run checkpoint after we wrote the commit to disk,
> but if things go wrong here (e.g. IOError when IFD deletes a pending file,
> OOM), then everything will go wrong (we won't even properly incref things,
> and may end out deleting wrong files if the user calls rollback, leaving a
> corrupt index).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
