[
https://issues.apache.org/jira/browse/SOLR-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-6507:
---------------------------
Attachment: SOLR-6507.patch
The attached patch has some quick and dirty tests demonstraitng these problems
as well as my porposed fix.
Rather then slap a bandaid on this i did a pretty serious overhaul of the way
the code in StatsComponent is laid out. This not only fixes the bug by
consolidating the param parsing logic into a single place, it helps ensure
param descrepencies like won't pop up as we add features (by consolidating the
param parsing logic into a single place), and it moves the direction i want to
move for features like SOLR-6354 & SOLR-6351.
* StatsInfo is now used for both for both distributed & local requests
** still one instance per request
* SimpleFacets has been renamed/refactored into "StatsField"
** now only models a single "stats.field" param (no more "iterating" local
state variables)
** API is now a lot more locked down and easier to understand (in my opinion)
** code that dealt with multiple "stats.field" params bubbled up to either
StatsInfo or the process() method of StatsComponent
----
There's still plenty of nocommits -- mostly dealing with javadocs and more
robust tests, but i think this is a good start in the right direction.
> various bugs using localparams with stats.field
> ------------------------------------------------
>
> Key: SOLR-6507
> URL: https://issues.apache.org/jira/browse/SOLR-6507
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Assignee: Hoss Man
> Attachments: SOLR-6507.patch
>
>
> StatsComponent has two different code paths for dealing with param parsing
> depending on wether it's a single node request of a distributed request,
> which results in two very differnet looking bugs (but in my opinion have the
> same root cause: bogus local param parsing):
> * the documented local params for stats.field don't work on distributed stats
> requests at all
> * per field "calcdistinct" doesn't work if localparms are used on single node
> request
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
