[ 
https://issues.apache.org/jira/browse/SOLR-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Davids updated SOLR-6496:
-------------------------------
    Attachment: SOLR-6496.patch

Initial patch that honors the timeAllowed request parameter. There aren't any 
tests included -- is there any objections to perhaps using a mocking library, 
it sure would make it much easier to perform unit testing on these negative 
cases. Mockito is my personal preference and is currently being used in 
Morphlines, but it will need to be included in the SolrJ test dependencies.

> LBHttpSolrServer should stop server retries after the timeAllowed threshold 
> is met
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-6496
>                 URL: https://issues.apache.org/jira/browse/SOLR-6496
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.9
>            Reporter: Steve Davids
>            Priority: Critical
>             Fix For: 4.11
>
>         Attachments: SOLR-6496.patch
>
>
> The LBHttpSolrServer will continue to perform retries for each server it was 
> given without honoring the timeAllowed request parameter. Once the threshold 
> has been met, you should no longer perform retries and allow the exception to 
> bubble up and allow the request to either error out or return partial results 
> per the shards.tolerant request parameter.
> For a little more context on how this is can be extremely problematic please 
> see the comment here: 
> https://issues.apache.org/jira/browse/SOLR-5986?focusedCommentId=14100991&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14100991
>  (#2)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to