[
https://issues.apache.org/jira/browse/LUCENE-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-5871:
---------------------------------------
Attachment: LUCENE-5871.iwclose.trunk.patch
LUCENE-5871.iwclose.4x.patch
Here's a patch for fixing IW.close on 4.x ... I also fixed trunk's close a bit
(put back the shouldClose() call), and added a couple test cases.
For 4.x, I also back-ported a bug fix + test that snuck in with LUCENE-4246.
I think it's ready...
> Simplify or remove use of Version in IndexWriterConfig
> ------------------------------------------------------
>
> Key: LUCENE-5871
> URL: https://issues.apache.org/jira/browse/LUCENE-5871
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Ryan Ernst
> Assignee: Ryan Ernst
> Fix For: 5.0
>
> Attachments: LUCENE-5871.iwclose.4x.patch,
> LUCENE-5871.iwclose.trunk.patch, LUCENE-5871.patch, LUCENE-5871.patch,
> LUCENE-5871.patch, LUCENE-5871.patch, LUCENE-5871.patch
>
>
> {{IndexWriter}} currently uses Version from {{IndexWriterConfig}} to
> determine the semantics of {{close()}}. This is a trapdoor for users, as
> they often default to just sending Version.LUCENE_CURRENT since they don't
> understand what it will be used for. Instead, we should make the semantics
> of close a direction option in IWC.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
