[
https://issues.apache.org/jira/browse/SOLR-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087226#comment-14087226
]
Shawn Heisey commented on SOLR-912:
-----------------------------------
I built a patch that eliminated SimpleOrderedMap, but it's huge and intrusive.
Based on how often SimpleOrderedMap is used and the number of times that a
SimpleOrderedMap object was actually named "nl" ... I am guessing that people
assumed they could rely on the note in the NamedList javadoc about
SimpleOrderedMap, or perhaps the notes in the javadoc for SimpleOrderedMap
itself (which contradicts what it says in NamedList).
If somebody knows how to actually implement what SimpleOrderedMap promises, we
might see a slight increase in Solr's performance, and the patch will be far
less intrusive.
> org.apache.solr.common.util.NamedList - Typesafe efficient variant -
> ModernNamedList introduced - implementing the same API as NamedList
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-912
> URL: https://issues.apache.org/jira/browse/SOLR-912
> Project: Solr
> Issue Type: Improvement
> Components: search
> Environment: Tomcat 6, JRE 6, Solr 1.3+ nightlies
> Reporter: Karthik K
> Priority: Minor
> Attachments: NLProfile.java, SOLR-912.patch, SOLR-912.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> The implementation of NamedList - while being fast - is not necessarily
> type-safe. I have implemented an additional implementation of the same -
> ModernNamedList (a type-safe variation providing the same interface as
> NamedList) - while preserving the semantics in terms of ordering of elements
> and allowing null elements for key and values (keys are always Strings ,
> while values correspond to generics ).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
