[
https://issues.apache.org/jira/browse/LUCENE-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071353#comment-14071353
]
David Smiley commented on LUCENE-5825:
--------------------------------------
I think the earlier patch was probably generated OK. The new one you posted is
definitely wrong as it only includes your last commit -- most likely because
you've been merging trunk into your branch (please don't do that next time). I
generated a diff this way:
{{git diff --no-prefix --no-color origin/trunk...shenoy/lucene-5825 --
lucene/benchmark/ > LUCENE-5825.patch}}
* --no-prefix: chops off the a/ & b/ git does by default on the paths.
* --no-color when I redirected stdout to a file it included the color codes
which rendered the file corrupt. I don't remember having to set this in the
past, but whatever.
* \-- lucene/benchmark: I think because you merged trunk, it included stuff
outside of the benchmark module, so this filtered it.
IntelliJ at least applied this patch fine.
I'll commit in a sec.
> Allowing the benchmarking algorithm to choose PostingsFormat
> ------------------------------------------------------------
>
> Key: LUCENE-5825
> URL: https://issues.apache.org/jira/browse/LUCENE-5825
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/benchmark
> Affects Versions: 5.0
> Reporter: Varun V Shenoy
> Priority: Minor
> Fix For: 5.0
>
> Attachments: LUCENE-5825.patch, LUCENE-5825.patch
>
>
> The algorithm file for benchmarking should allow PostingsFormat to be
> configurable.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
