[
https://issues.apache.org/jira/browse/SOLR-5495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058888#comment-14058888
]
Timothy Potter commented on SOLR-5495:
--------------------------------------
Hi Mark,
Awesome, thanks for the review ... there's one area in the CoreAdminHandler
waitForState that could use your review.
// TODO: This is funky but I've seen this in testing where the
replica asks the
// leader to be in recovery? Need to track down how that happens
... in the meantime,
// this is a safeguard
boolean leaderDoesNotNeedRecovery = (onlyIfLeader != null &&
onlyIfLeader &&
core.getName().equals(nodeProps.getStr("core")) &&
ZkStateReader.RECOVERING.equals(waitForState) &&
ZkStateReader.ACTIVE.equals(localState) &&
ZkStateReader.ACTIVE.equals(state));
Basically, at some point, I was seeing replicas ask active leaders to recover,
which I didn't think was a valid thing to do. I actually haven't seen this
occur in any of my testing so maybe I was just confused. We can definitely
remove that code if it's not valid, but wanted to make you aware that I had it
in there ;-)
> Recovery strategy for leader partitioned from replica case.
> -----------------------------------------------------------
>
> Key: SOLR-5495
> URL: https://issues.apache.org/jira/browse/SOLR-5495
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Timothy Potter
> Fix For: 4.9
>
> Attachments: SOLR-5495.patch, SOLR-5495.patch, SOLR-5495.patch
>
>
> We need to work out a strategy for the case of:
> Leader and replicas can still talk to ZooKeeper, Leader cannot talk to
> replica.
> We punted on this in initial design, but I'd like to get something in.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
