[ 
https://issues.apache.org/jira/browse/LUCENE-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hoss Man updated LUCENE-5790:
-----------------------------

    Attachment: LUCENE-5790.patch

Starting point for a more comprehensive test patch of the MutableValue API (it 
doesn't seem to have any specific unit tests yet -- just tests via Grouping)

This is the most trivial way to demonstrate the failure...

{noformat}
public void testDoubleTrivially() {
  MutableValueDouble xxx = new MutableValueDouble();
  xxx.exists = false;
  assertEquals(0, xxx.compareTo(xxx));
}
{noformat}

...a mutable double that does not exist can't be compared to itself.

Ebisawa observed simila problems in other MutableValue subclasses that we 
should also audit & test for.


> MutableValue compareTo impls seem to be broken for exists==false
> ----------------------------------------------------------------
>
>                 Key: LUCENE-5790
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5790
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Hoss Man
>         Attachments: LUCENE-5790.patch
>
>
> On the solr-user mailing list, Ebisawa & Alex both commented that they've 
> noticed bugs in the grouping code when some documents don't have values in 
> the grouping field.
> In Ebisawa's case, he tracked this down to what appears to be some bugs in 
> the logic of the "compareSameType" method of some of the MutableValue 
> implementations.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to