[
https://issues.apache.org/jira/browse/SOLR-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-6067:
---------------------------
Attachment: SOLR-6067.patch
i.e. the collector assignment's result is completely ignored.
Ah ... that was probably something i screwed up when shoehorning the patch into
trunk wasn't it? sorry about that.
bq. Added Grouping.java to this ticket, ...
Actually, I'd prefer to break that out into a separate ticket...
1) it's a refactor of similar logic, but it's not directly leveraging the other
changes you've made to SolrIndexSearcher
2) unlike the way the SolrIndexSearcher refactoring is very straight forward,
the Grouping changes are not so obvious to me -- in particular looking at the
patch i see this flow change (psuedo-code)...
{code:title=current code}
if (postFilter is not null) {
wrap postFilter arround allCollectors
allCollectors = postFilter
}
if (allCollectors is not null) {
execute time limited search on allCollectors
}
{code}
{code:title=in your patch}
if (allCollectors is not null) {
delegate to method that:
wraps allCollectors in postFilter and...
execute time limited search on allCollectors
}
{code}
...so basically the logic will now be very different if allCollectors is null
but postFilter isn't. Off the top of my head i don't know if that actually
happens, or if your code is actually more correct, but that uncertainty is why
i'd prefer to tackle that separately.
---
I've attached a patch containing just the SolrIndexSearcher.java portions of
your latest pull request, with some javadocs added to the new method.
Assuming tests pass, i'll commit this afternoon.
> add buildAndRunCollectorChain methods to reduce code duplication in
> SolrIndexSearcher, Grouping
> -----------------------------------------------------------------------------------------------
>
> Key: SOLR-6067
> URL: https://issues.apache.org/jira/browse/SOLR-6067
> Project: Solr
> Issue Type: Improvement
> Reporter: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-6067.patch, SOLR-6067.patch
>
>
> https://github.com/apache/lucene-solr/pull/48 has the proposed change.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
