[
https://issues.apache.org/jira/browse/LUCENE-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014966#comment-14014966
]
Robert Muir commented on LUCENE-5723:
-------------------------------------
Can you submit the idea to JavaCC. This is autogenerated code... FWIW
exceptions in java can be as fast as goto, so it could actually make things
slower depending...
> Performance improvements for FastCharStream
> -------------------------------------------
>
> Key: LUCENE-5723
> URL: https://issues.apache.org/jira/browse/LUCENE-5723
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/queryparser
> Reporter: Itamar Syn-Hershko
> Priority: Minor
>
> Hello from the .NET land,
> A user of ours has identified an optimization opportunity, although minor I
> think it points to a valid point - we should avoid using exceptions from
> controlling flow when possible.
> Here's the original ticket + commits to our codebase. If this looks valid to
> you too I can go ahead and prepare a PR.
> https://issues.apache.org/jira/browse/LUCENENET-541
> https://github.com/apache/lucene.net/commit/ac8c9fa809110ddb180bf7b2ce93e86270b39ff6
> https://git-wip-us.apache.org/repos/asf?p=lucenenet.git;a=blobdiff;f=src/core/QueryParser/QueryParserTokenManager.cs;h=ec09c8e451f7a7d1572fbdce4c7598e362526a7c;hp=17583d20f660fdb6e4aa86105c7574383f965ebe;hb=41ebbc2d;hpb=ac8c9fa809110ddb180bf7b2ce93e86270b39ff6
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
