[
https://issues.apache.org/jira/browse/LUCENE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013498#comment-14013498
]
Michael McCandless commented on LUCENE-5708:
--------------------------------------------
I agree that the distinction of "randomly test this PF via the generic
base test class" and the "specifically test tricky corner cases for
this particular PF" (e.g. TestBlockPostingsFormat/2/3.java) is
important, and the specific IWC settings for those tests are
necessary.
I reviewed all the test changes more closely, and found a couple other
places that needed to carry over explicit IWC changes after pulling a
random IWC (I'll commit shortly).
I think this is net/net good vs the clone we had before: it means we
are still randomly changing the things the test didn't care about, and
fixing the settings that it does.
> Remove IndexWriterConfig.clone
> ------------------------------
>
> Key: LUCENE-5708
> URL: https://issues.apache.org/jira/browse/LUCENE-5708
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 4.9, 5.0
>
> Attachments: LUCENE-5708.patch, LUCENE-5708.patch, LUCENE-5708.patch
>
>
> We originally added this clone to allow a single IWC to be re-used against
> more than one IndexWriter, but I think this is a mis-feature: it adds
> complexity to hairy classes (merge policy/scheduler, DW thread pool, etc.), I
> think it's buggy today.
> I think we should just disallow sharing: you must make a new IWC for a new
> IndexWriter.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
