[
https://issues.apache.org/jira/browse/LUCENE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-5708:
---------------------------------------
Attachment: LUCENE-5708.patch
New patch, I think it's ready; I'll commit soon...
bq. It looks to me that we should be able to make some fields final now that we
don't have a clone method anymore
+1, I fixed a few of these, and found a couple more "implements Cloneable" to
remove.
bq. (eg. MergePolicy.writer)
Looks like we'll remove IW as a field in MP/MS with LUCENE-5711.
> Remove IndexWriterConfig.clone
> ------------------------------
>
> Key: LUCENE-5708
> URL: https://issues.apache.org/jira/browse/LUCENE-5708
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 4.9, 5.0
>
> Attachments: LUCENE-5708.patch, LUCENE-5708.patch, LUCENE-5708.patch
>
>
> We originally added this clone to allow a single IWC to be re-used against
> more than one IndexWriter, but I think this is a mis-feature: it adds
> complexity to hairy classes (merge policy/scheduler, DW thread pool, etc.), I
> think it's buggy today.
> I think we should just disallow sharing: you must make a new IWC for a new
> IndexWriter.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
