[
https://issues.apache.org/jira/browse/LUCENE-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000801#comment-14000801
]
Uwe Schindler edited comment on LUCENE-5678 at 5/17/14 5:56 PM:
----------------------------------------------------------------
Very simple patch.
[~mikemccand]: It would be good to compare performance as a first review. We
can then merge this with OutputStreamDataOutput. An alternative would be to
nuke BufferedIndexOutput completely and use BufferedOutputStream in
combinations with java.util.zip.CheckedOutputStream (for the checksum)!
was (Author: thetaphi):
Very simple patch.
[~mikemccand]: It would be good to compare performance as a first review. We
can then merge this with OutputStreamDataOutput. An alternative would be to
nuke BufferedIndexOutput completely and use BufferedOutputStream!
> Investigate to use FileoutputStream instead of RandomAccessFile in
> FSIndexOutput
> --------------------------------------------------------------------------------
>
> Key: LUCENE-5678
> URL: https://issues.apache.org/jira/browse/LUCENE-5678
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/store
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Attachments: LUCENE-5678.patch
>
>
> We no longer allow seeking in IndexOutput, so there is no need to use
> RandomAccessFile. We can change this with a < 1 KiB patch.
> Further improvements would be to merge this with OutputStreamIndexOutput, so
> we get many simplifications.
> There is also no reason anymore to separate DataOutput from IndexOutput. The
> only additional thing is IndexOutput#getFilePointer(), which is handled by
> an internal counter (does not use getFilePointer of the underlying RAF) and
> checksums.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
