[
https://issues.apache.org/jira/browse/LUCENE-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000611#comment-14000611
]
Hoss Man commented on LUCENE-5663:
----------------------------------
bq. I think we should just 'shadow' the static method on NIO/MMAP to open NIO
and MMAP respectively.
An open method in each sub-class? Isn't that what the constructors are for?
The idea of deliberately shadowing a static method in all of the subclasses
smells really bad to me.
If we're going to have 4 diff static "open()" methods that return 3 diff impls
(3 fixed, and one hueristic in the abstract base class) then adding an
FSDirectoryFactory class to put them in and eliminating FSDirectory.open
certainly sounds like a cleaner solution.
> Fix FSDirectory.open API
> ------------------------
>
> Key: LUCENE-5663
> URL: https://issues.apache.org/jira/browse/LUCENE-5663
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
>
> Spinoff from LUCENE-5658
> {quote}
> This does not use NIOFSDir! open() is a static factory method on FSDirectory,
> just inherited to NIOFSDirectory.
> {quote}
> I think its confusing we have this method on FSDirectory, so its visible in
> subclasses. We should at least consider doing this in another way so its not
> confusing.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
