[
https://issues.apache.org/jira/browse/LUCENE-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-5660:
---------------------------------------
Attachment: LUCENE-5660.patch
Currently bad things happen if you send too-big an input to AnalyzingSuggester;
here's my current patch that just adds a missing low-level check to the
OfflineSorter so at least the user gets a clue that something was too big.
If we enforce stricter limits higher up then we can leave the assert isFinite
in place.
> AnalyzingSuggester needs reasonable defaults
> --------------------------------------------
>
> Key: LUCENE-5660
> URL: https://issues.apache.org/jira/browse/LUCENE-5660
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-5660.patch
>
>
> Issues like LUCENE-5628 LUCENE-5659 are hacks around the problem that the
> AnalyzingSuggester allows automata to "explode".
> I don't think we should try to hack up the automata lib to the point its
> un-understandable to support this, since its designed for smaller automata
> such as queries and is appropriate for that.
> We should instead just set appropriate limits out of box so
> AnalyzingSuggester doesnt blow up.
> Remember this is a suggester, it needs to be fast. The fact that the automata
> lib blows up on stupid unit tests or whatever are doing this, instead of
> being silently slow, is a good thing.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
