[ 
https://issues.apache.org/jira/browse/SOLR-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997793#comment-13997793
 ] 

Hoss Man commented on SOLR-6067:
--------------------------------

Hmmm.... with the patch, i'm seeing lots of tests tripping an assert in 
SolrIndexSearcher...

{noformat}
   [junit4]   2> 906349 T4720 oasc.SolrException.log ERROR 
java.lang.AssertionError
   [junit4]   2>                at 
org.apache.solr.search.SolrIndexSearcher.getDocListAndSetNC(SolrIndexSearcher.java:1701)
   [junit4]   2>                at 
org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1427)
   [junit4]   2>                at 
org.apache.solr.search.SolrIndexSearcher.access$100(SolrIndexSearcher.java:124)
   [junit4]   2>                at 
org.apache.solr.search.SolrIndexSearcher$3.regenerateItem(SolrIndexSearcher.java:503)
   [junit4]   2>                at 
org.apache.solr.search.LRUCache.warm(LRUCache.java:189)
   [junit4]   2>                at 
org.apache.solr.search.SolrIndexSearcher.warm(SolrIndexSearcher.java:2110)
   [junit4]   2>                at 
org.apache.solr.core.SolrCore$4.call(SolrCore.java:1718)
   [junit4]   2>                at 
java.util.concurrent.FutureTask.run(FutureTask.java:262)

...

   [junit4]    > Throwable #1: java.lang.AssertionError
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([6B71312FB526EB2B:CE319917776B3B23]:0)
   [junit4]    >        at 
org.apache.solr.search.SolrIndexSearcher.getDocListAndSetNC(SolrIndexSearcher.java:1701)
   [junit4]    >        at 
org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1427)
   [junit4]    >        at 
org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:512)
   [junit4]    >        at 
org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:461)
   [junit4]    >        at 
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:221)
   [junit4]    >        at 
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:135)
   [junit4]    >        at 
org.apache.solr.core.SolrCore.execute(SolrCore.java:1964)
   [junit4]    >        at 
org.apache.solr.util.TestHarness.query(TestHarness.java:295)
   [junit4]    >        at 
org.apache.solr.util.TestHarness.query(TestHarness.java:278)
   [junit4]    >        at 
org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:693)
   [junit4]    >        at 
org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:686)
   [junit4]    >        at 
org.apache.solr.TestTrie.testFacetField(TestTrie.java:280)
   [junit4]    >        at 
org.apache.solr.TestTrie.testTrieFacet_PrecisionStep(TestTrie.java:257)

...

   [junit4]    > Throwable #1: java.lang.AssertionError
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([6B71312FB526EB2B:741292EA5001AB22]:0)
   [junit4]    >        at 
org.apache.solr.search.SolrIndexSearcher.getDocListAndSetNC(SolrIndexSearcher.java:1701)
   [junit4]    >        at 
org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1427)
   [junit4]    >        at 
org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:512)
   [junit4]    >        at 
org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:461)
   [junit4]    >        at 
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:221)
   [junit4]    >        at 
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:135)
   [junit4]    >        at 
org.apache.solr.core.SolrCore.execute(SolrCore.java:1964)
   [junit4]    >        at 
org.apache.solr.util.TestHarness.query(TestHarness.java:295)
   [junit4]    >        at 
org.apache.solr.util.TestHarness.query(TestHarness.java:278)
   [junit4]    >        at 
org.apache.solr.SolrTestCaseJ4.assertJQ(SolrTestCaseJ4.java:785)
   [junit4]    >        at 
org.apache.solr.SolrTestCaseJ4.assertJQ(SolrTestCaseJ4.java:754)
   [junit4]    >        at 
org.apache.solr.search.TestFiltering.testRandomFiltering(TestFiltering.java:323)

{noformat}

...i don't have time to dig in right now, but i'll try to circle back and 
review more closely later.

> add buildAndRunCollectorChain method to reduce code duplication in 
> SolrIndexSearcher
> ------------------------------------------------------------------------------------
>
>                 Key: SOLR-6067
>                 URL: https://issues.apache.org/jira/browse/SOLR-6067
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-6067.patch
>
>
> https://github.com/apache/lucene-solr/pull/48 has the proposed change. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to