[
https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990282#comment-13990282
]
David Smiley commented on LUCENE-5645:
--------------------------------------
So it turns out this has to do with IntelliJ. When IntelliJ configures itself
off of a maven pom.xml, it apparently takes a close look at what system
properties are being passed to the Surefire plugin, which runs tests. If you
tell IntelliJ to run a test class, it automatically passes along all System
properties it saw that Surefire is configured to use (in addition to any you
explicitly configure in a run configuration). IntelliJ passes along the empty
string if the System property is empty. Apparently, an actual Maven Surefire
invoked test skips over empty-value properties and doesn't set those.
Well that was interesting, and I'll file a bug with Jetbrains, but nonetheless
I think my proposal in this issue remains sound -- don't try to parse
tests.seed if it's "" because we already know it won't parse and because
RandomizedTesting skips "" as well.
> StringHelper should check for empty string of "tests.seed" system property
> --------------------------------------------------------------------------
>
> Key: LUCENE-5645
> URL: https://issues.apache.org/jira/browse/LUCENE-5645
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 4.8, 5.0
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: 4.8.1, 5.0
>
>
> As of LUCENE-5604 (committed to v4.8), StringHelper will initialize
> GOOD_FAST_HASH_SEED based on the system property "tests.seed" if it is set.
> Unfortunately it doesn't do an empty-string check, and it's common at least
> in my setup that copies Lucene's maven pom.xml that the string will be empty
> unless I set it on the command line. FWIW Randomized Testing does do an
> empty-string check.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
