[
https://issues.apache.org/jira/browse/LUCENE-5622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979493#comment-13979493
]
Dawid Weiss commented on LUCENE-5622:
-------------------------------------
While annotating tests that do sysouts I came to the conclusion that it
shouldn't be an "all or nothing" threshold. It should be much like the memory
leak detector -- some sysouts per suite should be fine (say, 1kb), then it
should start failing and suggest to change some of the sysouts to if (VERBOSE)
or raise the limit by annotating the suite with a higher threshold.
This would make sense in that we could enable those checks by default without
additional jenkins jobs, special properties, etc. What do you think?
> Fail tests if they print, and tests.verbose is not set
> ------------------------------------------------------
>
> Key: LUCENE-5622
> URL: https://issues.apache.org/jira/browse/LUCENE-5622
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Dawid Weiss
> Attachments: LUCENE-5622.patch, LUCENE-5622.patch, LUCENE-5622.patch,
> LUCENE-5622.patch
>
>
> Some tests print so much stuff they are now undebuggable (see LUCENE-5612).
> I think its bad that the testrunner hides this stuff, we used to stay on top
> of it. Instead, whne tests.verbose is false, we should install a printstreams
> (system.out/err) that fail the test instantly because they are noisy.
> This will ensure that our tests don't go out of control.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
