[
https://issues.apache.org/jira/browse/SOLR-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977682#comment-13977682
]
Gregory Chanan commented on SOLR-6002:
--------------------------------------
bq. Just so that only one thread will actually do the close logic. You can
close an IndexWriter with either rollback or close and one of those might
internally call the other - so the CLOSE_LOCK just makes sure the
SolrIndexWriter close logic happens once. We don't use the this lock just so
that we don't end up conflicting with other uses.
Why is the CLOSE_LOCK static though?
bq. Though I guess that fine points of that are up for debate. Waiting for
merges can take a long time - perhaps we should just bail on them on shutdown -
you don't lose data from that. Or perhaps we should wait when we commit on
shutdown and not when we don't.
bq. I almost favor not waiting in either case - when I want to shutdown, I
want it to be fairly prompt. Perhaps it should be a configuration and default
to off. I don't want to tie all that into this issue though. We should probably
just wait for merges for now as I think it's been done for a long time.
Waiting for now with a config seems reasonable, but I don't have a strong
opinion.
> Fix a couple of ugly issues around SolrIndexWriter close and rollback as well
> as how SolrIndexWriter manages it's ref counted directory instance.
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-6002
> URL: https://issues.apache.org/jira/browse/SOLR-6002
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Priority: Critical
> Fix For: 4.9, 5.0
>
> Attachments: SOLR-6002.patch, SOLR-6002.patch, SOLR-6002.patch
>
>
> We tried jumping all kinds of hoops (unsuccessfully anyway) to *really*
> *really* close an IndexWriter in the past, but Lucene wouldn't let you. Now
> that is fixed in Lucene and we should update our close/rollback code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
