[ 
https://issues.apache.org/jira/browse/LUCENE-5613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972894#comment-13972894
 ] 

Robert Muir commented on LUCENE-5613:
-------------------------------------

Also for the record, its always sad to see this:

{code}
  // Fill in a BytesRef from term's length & bytes encoded in
  // byte block
  public void setBytesRef(BytesRef term, int textStart) {
{code}

This is a public method in a public class, so using a javadoc-style comment 
goes a long way :)

> ByteBlockPool's documentation is completely useless
> ---------------------------------------------------
>
>                 Key: LUCENE-5613
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5613
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Trivial
>
> This is a nice reusable component yet the documentation for it is completely 
> useless. There are also API elements that seem to be remnants of an ancient 
> past.
> Can we clean it up for 5.x?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to