[
https://issues.apache.org/jira/browse/SOLR-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shawn Heisey updated SOLR-5981:
-------------------------------
Attachment: SOLR-5981.patch
Proposed patch against trunk. It is a little more invasive than I had
originally planned.
I changed everything that was private to protected, with the exception of the
Logger object. If an extending object wants to do some logging, it will need
to create its own.
I also did some work to eliminate some of the warnings in eclipse. The imports
required a number of deletions, so I opted to reorganize them and changed the
wildcard import to specific imports. I did not do anything to fix the rawtypes
warnings, because I couldn't fix them without touching other files.
The getSolrWriter method did get some reformatting.
> Please change method visibility of getSolrWriter in DataImportHandler to
> public (or at least protected)
> -------------------------------------------------------------------------------------------------------
>
> Key: SOLR-5981
> URL: https://issues.apache.org/jira/browse/SOLR-5981
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Environment: Linux 3.13.9-200.fc20.x86_64
> Solr 4.6.0
> Reporter: Aaron LaBella
> Priority: Blocker
> Fix For: 4.6
>
> Attachments: SOLR-5981.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I've been using the org.apache.solr.handler.dataimport.DataImportHandler for
> a bit and it's an excellent model and architecture. I'd like to extend the
> usage of it to plugin my own DIHWriter, but, the code doesn't allow for it.
> Please change ~line 227 in the DataImportHander class to be:
> public SolrWriter getSolrWriter
> instead of:
> private SolrWriter getSolrWriter
> or, at a minimum, protected, so that I can extend DataImportHandler and
> override this method.
> Thank you *sincerely* in advance for the quick turn-around on this. If the
> change can be made in 4.6.0 and upstream, that'd be ideal.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
