[
https://issues.apache.org/jira/browse/SOLR-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955356#comment-13955356
]
Per Steffensen edited comment on SOLR-5939 at 3/31/14 4:32 PM:
---------------------------------------------------------------
Well, I happened to be reading the code trying to understand how it works,
during my work with SOLR-4470. I realized that this piece of code would not
work - by code inspection alone. Instead of fixing it (I had to concentrate on
SOLR-4470 stuff) I just added a few FIXME lines around where the problem is.
[~janhoy] is handling the SOLR-4470 patch now, and prefer that I open an issue
(this SOLR-5939) about the problem and just reference that from the code
instead of the FIXME description. So yes, I mentioned it before, in comments to
SOLR-4470.
I mentioned another issue with SolrCmdDistributor long time ago (see
SOLR-3428). I do not know exactly what happened to that one. We have the fix in
our version of Solr, but I am not sure what you did about it.
was (Author: steff1193):
Well, I happened to be reading the code trying to understand how it works,
during my work with SOLR-4470. Instead of fixing it (I had to concentrate on
SOLR-4470 stuff) I just added a few FIXME lines around where the problem is.
[~janhoy] is handling the SOLR-4470 patch now, and prefer that I open an issue
(this SOLR-5939) about the problem and just reference that from the code
instead of the FIXME description. So yes, I mentioned it before, in comments to
SOLR-4470.
I mentioned another issue with SolrCmdDistributor long time ago (see
SOLR-3428). I do not know exactly what happened to that one. We have the fix in
our version of Solr, but I am not sure what you did about it.
> Wrong request potentially on Error from StreamingSolrServer
> -----------------------------------------------------------
>
> Key: SOLR-5939
> URL: https://issues.apache.org/jira/browse/SOLR-5939
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Affects Versions: 5.0
> Reporter: Per Steffensen
> Labels: error, retry
> Fix For: 4.8, 5.0
>
> Attachments: SOLR-5939_demo_problem.patch
>
>
> In _StreamingSolrServer.getSolrServer|ConcurrentUpdateSolrServer.handleError_
> the _SolrCmdDistributor.Req req_ parameter is used for the _req_ field of all
> _error_'s created. This is also true for subsequent requests sent through the
> retuned ConcurrentUpdateSolrServer. This means a.o. that wrong request (the
> first request sent through this _ConcurrentUpdateSolrServer_) may be retried
> if case of errors executing one of the subsequent requests.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
