On 3/13/2014 10:18 PM, Артём Луканин wrote: > Yes, I was thinking about deprecating the old methods as well. > I'll try to add a patch > here: https://issues.apache.org/jira/browse/SOLR-2018
I started working on a patch to deprecate old commit methods, but further digging has revealed that all varieties of AbstractUpdateRequest#setAction have waitFlush as well, and that none of them actually *use* the parameter. Because of the way the method signatures in Java work, it won't be possible to just remove a boolean from the various setAction methods and deprecate the old versions ... it will need to be replaced with a whole new name. If it's an acceptable path, I can deprecate all of the setAction methods and create a series of setUpdateAction methods to replace them. What do the senior committers think about this? SOLR-2018 seems to have been filed with the idea of actually figuring out how to properly implement waitFlush. Mark Miller took ownership of the issue earlier today ... are we implementing or fully ripping out? Thanks, Shawn --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
