GitHub user shebiki opened a pull request:
https://github.com/apache/lucene-solr/pull/40
Removal of Scorer.weight
I've been playing with reducing the dependency between BooleanWeight,
BooleanScorer, and BooleanScorer2. Instead of letting the scorers generate
their coord factors, now BooleanWeight generates them in one place for all the
scorers that it instantiates. After seeing how smoothly that went, I decided to
try and push it forward a little by removing Scorer.weight and the need to pass
in a weight (or null) to Scorer's constructor.
The tests green bar with `tests.disableHdfs=true` and `tests.slow=false`.
What do you guys think? I'm happy to adjust and port to trunk if you are
interested.
--Terry
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shebiki/lucene-solr weight-scorer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/40.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #40
----
commit db57c8032c717c06b1244b7e0a560d8a63f969d8
Author: Terry Smith <[email protected]>
Date: 2014-03-10T17:17:55Z
Makes BooleanWeight pass the coord factors into BooleanScorer and
BooleanScorer2. Both now just require a regular Weight instead of a
BooleanWeight.
commit 00740d6287b2f9b32f2c9c83ac6b61fb31f6aa78
Author: Terry Smith <[email protected]>
Date: 2014-03-11T01:16:29Z
Adds an explict ToParentBlockJoinQuery reference to the
ToParentBlockJoinQuery.BlockJoinScorer so ToParentBlockJoinCollector can
retrieve it directly instead of using Scorer.getWeight().
commit 07a41a91bb9b9c9196e6e8b9f0fd505856bc5d23
Author: Terry Smith <[email protected]>
Date: 2014-03-11T02:05:23Z
Removes last two references to Scorer.getWeight().
commit 5b99aafeec3ada0a1e644385d4c52901dc5153d4
Author: Terry Smith <[email protected]>
Date: 2014-03-11T02:31:59Z
Removes Scorer.weight and getWeight().
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
